This repository has been archived by the owner on Nov 12, 2022. It is now read-only.
Link cleanup #197
Merged
Link cleanup #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Link to mozjs_sys to pull in deps
|
@bors-servo r+ Reviewed 2 of 3 files at r1, 1 of 1 files at r2. Comments from the review on Reviewable.io |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
|
📌 Commit 88dd3c7 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Sep 21, 2015
Link cleanup r? @metajack @mbrubeck CC @alexcrichton <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/197) <!-- Reviewable:end -->
|
💔 Test failed - cargo-mac |
|
This is bug rust-lang/rust#28559, which should be fixed in tomorrow's nightly. |
|
@bors-servo retry (the new nightly should fix this failure) |
bors-servo
pushed a commit
that referenced
this pull request
Sep 22, 2015
Link cleanup r? @metajack @mbrubeck CC @alexcrichton <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/197) <!-- Reviewable:end -->
|
☀️ Test successful - cargo-linux, cargo-mac |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @metajack @mbrubeck
CC @alexcrichton