Skip to content

/ rust-mozjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the result of JS_DefineFunction in the example. #199

Merged
merged 1 commit into from Oct 8, 2015
Merged

Check the result of JS_DefineFunction in the example. #199

merged 1 commit into from Oct 8, 2015

Conversation

@Ms2ger
Copy link
Collaborator

Ms2ger commented Oct 8, 2015

Review on Reviewable
@jdm
Copy link
Member

jdm commented Oct 8, 2015

I think this will be easier to read as:

let func = JS_DefineFunction(...);
assert!(!func.is_null());
@Ms2ger
Check the result of JS_DefineFunction in the example.
Loading status checks…
70c1273
@Ms2ger Ms2ger force-pushed the check-example branch from e8ce201 to 70c1273 Oct 8, 2015
@jdm
Copy link
Member

jdm commented Oct 8, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 8, 2015

📌 Commit 70c1273 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 8, 2015

⌛ Testing commit 70c1273 with merge d368670...
bors-servo pushed a commit that referenced this pull request Oct 8, 2015
bors-servo
Auto merge of #199 - servo:check-example, r=jdm
Loading status checks…
d368670 
Check the result of JS_DefineFunction in the example.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/199)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 8, 2015

☀️ Test successful - travis
@bors-servo bors-servo merged commit 70c1273 into master Oct 8, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/push The Travis CI build passed
Details
homu Test successful
Details
@frewsxcv frewsxcv deleted the check-example branch Oct 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Ms2ger @jdm @bors-servo
You can’t perform that action at this time.