Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Windows #205

Merged
merged 1 commit into from Oct 21, 2015
Merged

Add support for Windows #205

merged 1 commit into from Oct 21, 2015

Conversation

@vvuk
Copy link
Contributor

vvuk commented Oct 20, 2015

Small build fixes for Windows

Review on Reviewable

@metajack
Copy link
Contributor

metajack commented Oct 20, 2015

@bors-servo r+


Reviewed 2 of 2 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from the review on Reviewable.io

@bors-servo
Copy link
Contributor

bors-servo commented Oct 20, 2015

📌 Commit 53807af has been approved by metajack

@bors-servo
Copy link
Contributor

bors-servo commented Oct 20, 2015

Testing commit 53807af with merge 8fdf2c8...

bors-servo pushed a commit that referenced this pull request Oct 20, 2015
bors-servo
Add support for Windows

Small build fixes for Windows

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/205)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 21, 2015

☀️ Test successful - travis

@bors-servo bors-servo merged commit 53807af into servo:master Oct 21, 2015
1 check was pending
1 check was pending
homu Testing commit 53807af with merge 8fdf2c8...
Details
@bors-servo
Copy link
Contributor

bors-servo commented Oct 21, 2015

The latest upstream changes (presumably #205) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.