Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIntroduce define_methods and define_properties functions. #206
Conversation
src/rust.rs
Outdated
| use jsval::UndefinedValue; | ||
| use glue::{CreateAutoObjectVector, AppendToAutoObjectVector, DeleteAutoObjectVector}; | ||
| use glue::{NewCompileOptions, DeleteCompileOptions}; | ||
| use default_stacksize; | ||
| use default_heapsize; | ||
|
|
||
| fn ok(b: bool) -> Result<(), ()> { |
This comment has been minimized.
This comment has been minimized.
jdm
Oct 23, 2015
Member
I'd prefer a to_result method defined on bool; I find it really easy to misread ok(something) as Ok(something).
This comment has been minimized.
This comment has been minimized.
These are based on the functions of the same name in Servo's script::dom::bindings::utils.
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 24, 2015
Introduce define_methods and define_properties functions. These are based on the functions of the same name in Servo's script::dom::bindings::utils. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/206) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ms2ger commentedOct 23, 2015
These are based on the functions of the same name in Servo's
script::dom::bindings::utils.