Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMark unsafe functions unsafe. #207
Merged
Conversation
All of those can trivially be made to crash by passing an invalid JSContext pointer.
|
@bors-servo r+ Bonus readability! Reviewed 1 of 1 files at r1. Comments from the review on Reviewable.io |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 28, 2015
Mark unsafe functions unsafe. All of those can trivially be made to crash by passing an invalid JSContext pointer. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/207) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ms2ger commentedOct 28, 2015
All of those can trivially be made to crash by passing an invalid JSContext
pointer.