Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upError reporting strings are Latin1, not UTF-8. #208
Conversation
Because the best way to convert from a 16-bit encoding to an 8-bit encoding is obviously truncation.
|
Have you tried using report->ucmessage? |
|
Just tried it... it contains the exact same Latin1 string inflated to u16. |
|
Hmm I expected it to be the other way around. For example, in http://mxr.mozilla.org/mozilla-central/source/js/src/jscntxt.cpp#650 , ucmessage is the original string before truncation to latin1. |
|
Added commit to use ucmessage. You can test for yourself if you want. |
eefriedman
force-pushed the
eefriedman:latin1-string
branch
2 times, most recently
from
bc3d890
to
5a5e090
As far as I can tell, it's precisely the same string as message... but it's possible this might lead to better error reporting in some obscure case I didn't run into.
|
Oops; not sure how I forgot it was in the standard library. Updated. |
|
@michaelwu Ping. |
|
@bors-servo r+ |
|
Nothing is happening here; do I need to file a bug against saltfs or something? |
|
@bors-servo: r=michaelwu |
|
|
Error reporting strings are Latin1, not UTF-8. Because the best way to convert from a 16-bit encoding to an 8-bit encoding is obviously truncation. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/208) <!-- Reviewable:end -->
|
|
|
The build timed out during the Spidermonkey build. The configuration probably needs to be changed somehow. |
|
@bors-servo: retry |
Error reporting strings are Latin1, not UTF-8. Because the best way to convert from a 16-bit encoding to an 8-bit encoding is obviously truncation. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/208) <!-- Reviewable:end -->
|
|
|
Bah, we're being bitten by libc here. #211 needs to merge first. |
|
@bors-servo: retry |
Error reporting strings are Latin1, not UTF-8. Because the best way to convert from a 16-bit encoding to an 8-bit encoding is obviously truncation. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/208) <!-- Reviewable:end -->
|
|
eefriedman commentedOct 29, 2015
Because the best way to convert from a 16-bit encoding to an 8-bit
encoding is obviously truncation.