Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set nativeRegExp to true rather than false. #210

Merged
merged 1 commit into from Nov 3, 2015

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Nov 3, 2015

Improves SpiderMonkey regex performance, and gives us the same default as Firefox.

Review on Reviewable

@Ms2ger
Copy link
Collaborator

Ms2ger commented Nov 3, 2015

@bors-servo r+

Thank you for your PR.

@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2015

📌 Commit 0e11a19 has been approved by Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2015

Testing commit 0e11a19 with merge 7cc3064...

bors-servo added a commit that referenced this pull request Nov 3, 2015
Set nativeRegExp to true rather than false.

Improves SpiderMonkey regex performance, and gives us the same default as Firefox.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/210)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2015

☀️ Test successful - travis

@bors-servo bors-servo merged commit 0e11a19 into servo:master Nov 3, 2015
1 check passed
1 check passed
homu Test successful
Details
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2015

The latest upstream changes (presumably #210) made this pull request unmergeable. Please resolve the merge conflicts.

@asajeffrey asajeffrey deleted the asajeffrey:native_regexp branch Nov 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.