servo / rust-mozjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the `consts` module public #216

Closed

emilio wants to merge 1 commit into servo:master from emilio:pub-consts

Member

emilio commented Nov 11, 2015


        Make the `consts` module public

ce001ea

emilio added a commit to emilio/servo that referenced this pull request


        Implement WebIDL sequence return value using `JS_NewArrayObject1`

105f2e9

This commits changes the creation of the array to use the length, and
sets the elements later.

Reference implementation:
https://github.com/mozilla/gecko-dev/blob/07ed19e582faf40f5f72567169db62452f6c6dc9/js/xpconnect/public/nsTArrayHelpers.h#L16

Depends on: servo/rust-mozjs#216

emilio added a commit to emilio/servo that referenced this pull request


        Implement WebIDL sequence return value using `JS_NewArrayObject1`

1f00c14

This commits changes the creation of the array to use the length, and
sets the elements later.

Reference implementation:
https://github.com/mozilla/gecko-dev/blob/07ed19e582faf40f5f72567169db62452f6c6dc9/js/xpconnect/public/nsTArrayHelpers.h#L16

Depends on: servo/rust-mozjs#216

Member Author

emilio commented Nov 11, 2015

It's needed for servo/servo#8412

r? @jdm (or anyone else really)

Member

jdm commented Nov 11, 2015

Note that all the constants are still available through js:: instead of js::consts.

Member Author

emilio commented Nov 11, 2015

Arrgh my fault... Sorry about that

emilio closed this

emilio deleted the emilio:pub-consts branch

emilio mentioned this pull request

Updated pub/priv #234

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.