Skip to content

/ rust-mozjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conversions: Implement FromJSValConvertible for Vec<T> #226

Closed
wants to merge 3 commits into from
Closed

conversions: Implement FromJSValConvertible for Vec<T> #226

wants to merge 3 commits into from
+35 −15

Commits on Dec 30, 2015

  1. [wip] Try to generalise it using ForOfIterator 

    This actually fails with a trap (at the assertion in `Rooted<T>::drop`).
    @emilio
    emilio committed Dec 30, 2015
    4c04a59

  2. [wip] Add minimal test case and comment Rooted<T>::drop 

    It works this way, even though we can't do this :(
    @emilio
    emilio committed Dec 30, 2015
    5237a74

  3. Remove Rooted<T> drop flag 

    This actually works, even though it feels too hacky...
    @emilio
    emilio committed Dec 30, 2015
    21b6f4f
You can’t perform that action at this time.