Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conversions: Implement FromJSValConvertible for Vec<T> #226

Closed
wants to merge 3 commits into from
Closed
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

[wip] Add minimal test case and comment Rooted<T>::drop

It works this way, even though we can't do this :(
  • Loading branch information
emilio committed Dec 30, 2015
commit 5237a749e4d084165769c6bde683b90cd91b3977
@@ -328,6 +328,7 @@ impl<T: Copy> MutableHandle<T> {
}
}

/*
impl<T> Drop for Rooted<T> {
fn drop(&mut self) {
unsafe {
@@ -336,6 +337,7 @@ impl<T> Drop for Rooted<T> {
}
}
}
*/

impl CustomAutoRooter {
pub fn new(cx: *mut JSContext, vftable: &'static _vftable_CustomAutoRooter)
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.