Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upconversions: Make the config param generic #230
Merged
Conversation
This allows to convert all types, not just those with `Config=()`
|
r? @nox |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 31, 2015
conversions: Make the config param generic This allows to convert all types, not just those with `Config=()`. This flaw was discovered while adding tests for it in `TestBindings`. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/230) <!-- Reviewable:end -->
|
|
bors-servo
merged commit 31866ac
into
servo:master
1 check was pending
1 check was pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emilio commentedDec 31, 2015
This allows to convert all types, not just those with
Config=().This flaw was discovered while adding tests for it in
TestBindings.