Skip to content

/ rust-mozjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ccache #241

Merged
merged 1 commit into from Jul 13, 2016
Merged

Use ccache #241

merged 1 commit into from Jul 13, 2016
+9 −2

Conversation

@Manishearth
Copy link
Member

Manishearth commented Feb 11, 2016

Not sure if this works.

r? @larsbergstrom

Review on Reviewable
@Manishearth Manishearth force-pushed the all-hail-ccache branch from f27416b to ff2f8cd Feb 11, 2016
@jdm
Copy link
Member

jdm commented Feb 11, 2016 

configure: error: ccache not found

make: *** [all] Error 1

thread '<main>' panicked at 'assertion failed: result.success()', /home/travis/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/build.rs:17
@Manishearth Manishearth force-pushed the all-hail-ccache branch 2 times, most recently from 0691bad to caa7401 Feb 11, 2016
@jdm
Copy link
Member

jdm commented May 27, 2016

Want to rebase and squash this? It seems like the second commit worked.
@Manishearth Manishearth force-pushed the all-hail-ccache branch from 7e07ce8 to cf4bf44 May 27, 2016
@Manishearth
Copy link
Member Author

Manishearth commented May 27, 2016

Done
@jdm
Copy link
Member

jdm commented May 27, 2016

@bors-servo: r+
@Manishearth
Use ccache
Verified
This commit was signed with a verified signature.
Manishearth Manish Goregaokar
GPG key ID: 3BBF4D3E2EF79F98 Learn about signing commits
Loading status checks…
ad76c4d
@Manishearth Manishearth force-pushed the all-hail-ccache branch from cf4bf44 to ad76c4d May 27, 2016
@Manishearth
Copy link
Member Author

Manishearth commented May 27, 2016

@bors-servo r=jdm
@jdm
Copy link
Member

jdm commented Jul 13, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 13, 2016

📌 Commit ad76c4d has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jul 13, 2016

⌛ Testing commit ad76c4d with merge 001f492...
bors-servo added a commit that referenced this pull request Jul 13, 2016
@bors-servo
Auto merge of #241 - servo:all-hail-ccache, r=jdm
Loading status checks…
001f492 
Use ccache

Not sure if this works.

r? @larsbergstrom

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/241)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 13, 2016

☀️ Test successful - travis
@bors-servo bors-servo merged commit ad76c4d into master Jul 13, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/push The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the all-hail-ccache branch Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Manishearth @jdm @bors-servo
You can’t perform that action at this time.