Skip to content

/ rust-mozjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the build warning-free. #244

Merged
merged 4 commits into from Mar 7, 2016
Merged

Make the build warning-free. #244

merged 4 commits into from Mar 7, 2016
+5 −5

Conversation

@Ms2ger
Copy link
Collaborator

Ms2ger commented Mar 7, 2016

Review on Reviewable
Ms2ger added 4 commits Mar 7, 2016
@Ms2ger
Remove unused import.
8b289cf
@Ms2ger
Replace deprecated utf16_units method.
40e5734
@Ms2ger
Make the RootKind trait public to fix a build warning.
94e6f4b
@Ms2ger
Silence long-ignored warnings about Drop for C types.
Loading status checks…
24cd1e7
@nox
Copy link
Member

nox commented Mar 7, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2016

📌 Commit 24cd1e7 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2016

⌛ Testing commit 24cd1e7 with merge e88d167...
bors-servo added a commit that referenced this pull request Mar 7, 2016
@bors-servo
Auto merge of #244 - servo:warn, r=nox
Loading status checks…
e88d167 
Make the build warning-free.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/244)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2016

☀️ Test successful - travis
@bors-servo bors-servo merged commit 24cd1e7 into master Mar 7, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/push The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the warn branch Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Ms2ger @nox @bors-servo
You can’t perform that action at this time.