Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSet the native stack quota per Gecko's defaults to defend against JavaScript stack overflows. #249
Conversation
|
What about adding a test to src/tests.rs that initializes a basic global object, then evaluates |
|
Sure, sounds like a good idea. |
|
Test added. r? @jdm |
JavaScript stack overflows. Addresses servo/servo#10229.
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 30, 2016
Set the native stack quota per Gecko's defaults to defend against JavaScript stack overflows. Addresses servo/servo#10229. r? @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/249) <!-- Reviewable:end -->
|
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedMar 29, 2016
Addresses servo/servo#10229.
r? @jdm
This change is