Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap all the code in Runtime::new in a single unsafe block. #250

Merged
merged 1 commit into from Mar 30, 2016
Merged

Conversation

@Ms2ger
Copy link
Collaborator

Ms2ger commented Mar 30, 2016

This change is Reviewable

@KiChjang
Copy link
Member

KiChjang commented Mar 30, 2016

@KiChjang KiChjang self-assigned this Mar 30, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2016

📌 Commit 86efb1a has been approved by KiChjang

@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2016

Testing commit 86efb1a with merge 1bda8e8...

bors-servo added a commit that referenced this pull request Mar 30, 2016
Wrap all the code in Runtime::new in a single unsafe block.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/250)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2016

💔 Test failed - travis

@Ms2ger
Copy link
Collaborator Author

Ms2ger commented Mar 30, 2016

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2016

Testing commit 86efb1a with merge 6f1eb4e...

bors-servo added a commit that referenced this pull request Mar 30, 2016
Wrap all the code in Runtime::new in a single unsafe block.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/250)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2016

☀️ Test successful - travis

@bors-servo bors-servo merged commit 86efb1a into master Mar 30, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/push The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the rt-unsafe branch Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.