Skip to content

/ rust-mozjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followups to the SpiderMonkey upgrade. #261

Merged
merged 2 commits into from Apr 27, 2016
Merged

Followups to the SpiderMonkey upgrade. #261

merged 2 commits into from Apr 27, 2016
+9 −7

Conversation

@Ms2ger
Copy link
Collaborator

Ms2ger commented Apr 27, 2016 •
edited by larsbergstrom

This change is Reviewable
Ms2ger added 2 commits Apr 27, 2016
@Ms2ger
Improve the names of JSErrorFormatStrings.
bbf300d
@Ms2ger
Use some local variables to make Heap methods more readable.
Loading status checks…
d4652d5
@Ms2ger
Copy link
Collaborator Author

Ms2ger commented Apr 27, 2016 •
edited by larsbergstrom

Because this idiot forgot he actually did have review comments.

r? @nox
@nox
Copy link
Member

nox commented Apr 27, 2016 •
edited by larsbergstrom

Ah ah nice.

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2016

📌 Commit d4652d5 has been approved by nox
1 similar comment
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2016

📌 Commit d4652d5 has been approved by nox
bors-servo added a commit that referenced this pull request Apr 27, 2016
@bors-servo
Auto merge of #261 - servo:smup-followup, r=nox
Loading status checks…
ceaf6d8 
Followups to the SpiderMonkey upgrade.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/261)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2016

⌛ Testing commit d4652d5 with merge ceaf6d8...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2016

☀️ Test successful - travis
@bors-servo bors-servo merged commit d4652d5 into master Apr 27, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/push The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the smup-followup branch Apr 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Ms2ger @nox @bors-servo
You can’t perform that action at this time.