Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followups to the SpiderMonkey upgrade. #261

Merged
merged 2 commits into from Apr 27, 2016
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Prev

Use some local variables to make Heap methods more readable.

  • Loading branch information
Ms2ger committed Apr 27, 2016
commit d4652d5bfe5015cb8f99171174d4fd806defdb1c
@@ -511,9 +511,10 @@ impl GCMethods<Value> for Value {
impl<T: GCMethods<T> + Copy> Heap<T> {
pub fn set(&mut self, v: T) {
unsafe {
let prev = *self.ptr.get();
*self.ptr.get() = v;
T::post_barrier(self.ptr.get(), prev, v);
let ptr = self.ptr.get();
let prev = *ptr;
*ptr = v;
T::post_barrier(ptr, prev, v);
}
}

@@ -551,8 +552,9 @@ impl Default for Heap<Value> {
impl<T: GCMethods<T> + Copy> Drop for Heap<T> {
fn drop(&mut self) {
unsafe {
if !(*self.ptr.get()).is_dropped() {
T::post_barrier(self.ptr.get(), *self.ptr.get(), T::initial());
let ptr = self.ptr.get();
if !(*ptr).is_dropped() {
T::post_barrier(ptr, *ptr, T::initial());
}
}
}
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.