Skip to content

/ rust-mozjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Request handling into Runtime. #263

Merged
merged 2 commits into from May 13, 2016
Merged

Move Request handling into Runtime. #263

merged 2 commits into from May 13, 2016

Conversation

@Ms2ger
Copy link
Collaborator

Ms2ger commented May 13, 2016 •
edited by larsbergstrom

This change is Reviewable
Ms2ger added 2 commits May 13, 2016
@Ms2ger
Move Request handling into Runtime (fixes #259).
b52a19a
@Ms2ger
Remove unused extern crate.
Loading status checks…
449d2f6
@nox
Copy link
Member

nox commented May 13, 2016

  • Are we sure this is safe?
  • You didn't remove libc from Cargo.toml. Was that on purpose?

r=me after these two questions are addressed.
@nox
Copy link
Member

nox commented May 13, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2016

📌 Commit 449d2f6 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2016

⌛ Testing commit 449d2f6 with merge 2bcfb73...
bors-servo added a commit that referenced this pull request May 13, 2016
@bors-servo
Auto merge of #263 - servo:requests, r=nox
Loading status checks…
2bcfb73 
Move Request handling into Runtime.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/263)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2016

☀️ Test successful - travis
@bors-servo bors-servo merged commit 449d2f6 into master May 13, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/push The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the requests branch May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Ms2ger @nox @bors-servo
You can’t perform that action at this time.