Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGeneralise Vec::<T>::from_jsval with ForOfIterator #264
Conversation
src/conversions.rs
Outdated
| }; | ||
|
|
||
| if !iterator.init(value, NonIterableBehavior::AllowNonIterable) { | ||
| throw_type_error(cx, "Value is not iterable"); |
This comment has been minimized.
This comment has been minimized.
Ms2ger
May 18, 2016
Collaborator
No need to throw here, but you should if !iterator.valueIsIterable()
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 19, 2016
Generalise Vec::<T>::from_jsval with ForOfIterator <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/264) <!-- Reviewable:end -->
|
|
nox
added a commit
to nox/servo
that referenced
this pull request
May 19, 2016
This pulls in servo/rust-mozjs#264.
bors-servo
added a commit
to servo/servo
that referenced
this pull request
May 19, 2016
(Do not merge) Update js to 3352139c1dedbdff5fe1078152f46522cd04b2f3 This pulls in servo/rust-mozjs#264.
nox
added a commit
to nox/servo
that referenced
this pull request
May 19, 2016
This pulls in servo/rust-mozjs#264.
bors-servo
added a commit
to servo/servo
that referenced
this pull request
May 19, 2016
Update js to 3352139c1dedbdff5fe1078152f46522cd04b2f3 This pulls in servo/rust-mozjs#264. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11263) <!-- Reviewable:end -->
bors-servo
added a commit
to servo/servo
that referenced
this pull request
May 19, 2016
Update js to 3352139c1dedbdff5fe1078152f46522cd04b2f3 This pulls in servo/rust-mozjs#264. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11263) <!-- Reviewable:end -->
zakorgy
added a commit
to zakorgy/servo
that referenced
this pull request
May 26, 2016
This pulls in servo/rust-mozjs#264.
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 1, 2019
…04b2f3 (from nox:forof); r=Ms2ger This pulls in servo/rust-mozjs#264. Source-Repo: https://github.com/servo/servo Source-Revision: 5376bdaf48c5bfc4b17522607b1010f96d057b8e UltraBlame original commit: 133e7853898969ee60e423d5952ff876e015ff3e
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…04b2f3 (from nox:forof); r=Ms2ger This pulls in servo/rust-mozjs#264. Source-Repo: https://github.com/servo/servo Source-Revision: 5376bdaf48c5bfc4b17522607b1010f96d057b8e UltraBlame original commit: 133e7853898969ee60e423d5952ff876e015ff3e
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…04b2f3 (from nox:forof); r=Ms2ger This pulls in servo/rust-mozjs#264. Source-Repo: https://github.com/servo/servo Source-Revision: 5376bdaf48c5bfc4b17522607b1010f96d057b8e UltraBlame original commit: 133e7853898969ee60e423d5952ff876e015ff3e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nox commentedMay 18, 2016
•
edited by larsbergstrom
This change is