Skip to content

/ rust-mozjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some handle improvements. #275

Merged
merged 2 commits into from Jun 28, 2016
Merged

Some handle improvements. #275

merged 2 commits into from Jun 28, 2016

Conversation

@Ms2ger
Copy link
Collaborator

Ms2ger commented Jun 28, 2016 •
edited by larsbergstrom

This change is Reviewable
Ms2ger added 2 commits Jun 28, 2016
@Ms2ger
Remove MutableHandle::to_handle.
b89c3ac 
It is redundant with MutableHandle::handle.
@Ms2ger
Remove unnecessary Copy bounds on handle methods.
Loading status checks…
67bebf2
@Ms2ger Ms2ger force-pushed the handles branch from 9bcccaf to 67bebf2 Jun 28, 2016
@nox
Copy link
Member

nox commented Jun 28, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 28, 2016

📌 Commit 67bebf2 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Jun 28, 2016

⌛ Testing commit 67bebf2 with merge fb84926...
bors-servo added a commit that referenced this pull request Jun 28, 2016
@bors-servo
Auto merge of #275 - servo:handles, r=nox
Loading status checks…
fb84926 
Some handle improvements.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/275)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 28, 2016

☀️ Test successful - travis
@bors-servo bors-servo merged commit 67bebf2 into master Jun 28, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/push The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the handles branch Jun 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Ms2ger @nox @bors-servo
You can’t perform that action at this time.