Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some handle improvements. #275

Merged
merged 2 commits into from Jun 28, 2016
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next

Remove MutableHandle::to_handle.

It is redundant with MutableHandle::handle.
  • Loading branch information
Ms2ger committed Jun 28, 2016
commit b89c3ac9b662d245956b4673bdfe8c06ba3bb0ee
@@ -393,12 +393,6 @@ impl<T: Copy> MutableHandle<T> {
ptr: ptr,
}
}

pub fn to_handle(&self) -> Handle<T> {
unsafe {
Handle::from_marked_location(self.ptr as *const _)
}
}
}

impl<T: Copy> Deref for MutableHandle<T> {
@@ -679,7 +673,7 @@ impl JSJitGetterCallArgs {
impl JSJitSetterCallArgs {
pub fn get(&self, i: u32) -> HandleValue {
assert!(i == 0);
self._base.to_handle()
self._base.handle()
}
}

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.