Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upadd function 'assert' to JavaScript global #28
Closed
Conversation
mmatyas
pushed a commit
to mmatyas/rust-mozjs
that referenced
this pull request
Jul 30, 2015
Fix debug and release compiles.
tschneidereit
pushed a commit
to tschneidereit/rust-mozjs
that referenced
this pull request
Aug 26, 2017
Rustup 2015 01 31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
evilpie commentedAug 28, 2013
This adds an "assert" function that I believe behaves kind of like the assert! macro, but instead of aborting we throw an exception. This exception is actually catchable which is inline with assertEq used in SpiderMonkey and has never really caused issues.
The idea is that we would remove this function and replace it with something defined in a test harness later.