Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a custom path to bindgen in etc/bindings.sh #288

Merged
merged 1 commit into from Aug 22, 2016

Conversation

@fitzgen
Copy link
Member

fitzgen commented Aug 19, 2016

This change is Reviewable

@fitzgen
Copy link
Member Author

fitzgen commented Aug 19, 2016

r? @Ms2ger

@Ms2ger
Copy link
Collaborator

Ms2ger commented Aug 22, 2016

Looks like we're getting to the point we should rewrite this script in python, but if it works, this is fine for now.

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Aug 22, 2016

📌 Commit ce7cee8 has been approved by Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented Aug 22, 2016

Testing commit ce7cee8 with merge c5a3b61...

bors-servo added a commit that referenced this pull request Aug 22, 2016
Allow a custom path to bindgen in etc/bindings.sh

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/288)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 22, 2016

☀️ Test successful - status-appveyor, status-travis

@bors-servo bors-servo merged commit ce7cee8 into servo:master Aug 22, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.