Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove unsafe_no_drop_flag #298
Merged
+3
−473
Conversation
nox
changed the title
|
r=me when it's ready to merge |
nox
changed the title
|
@bors-servo r=metajack |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 26, 2016
Remove unsafe_no_drop_flag <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/298) <!-- Reviewable:end -->
|
|
|
Needs rust-lang/rust#36008. |
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Aug 28, 2016
Remove unsafe_no_drop_flag <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/298) <!-- Reviewable:end -->
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Aug 28, 2016
Remove unsafe_no_drop_flag <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/298) <!-- Reviewable:end -->
|
|
|
@bors-servo r+ |
|
|
|
@bors-servo retry force |
|
@bors-servo r=metajack |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 28, 2016
Remove unsafe_no_drop_flag <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/298) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nox commentedAug 26, 2016
•
edited by larsbergstrom
This change is