Skip to content

/ rust-mozjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ToJSValConvertible for NonZero<*mut JSObject> #299

Merged
merged 2 commits into from Aug 30, 2016
Merged

Implement ToJSValConvertible for NonZero<*mut JSObject> #299

merged 2 commits into from Aug 30, 2016

Conversation

@nox
Copy link
Member

nox commented Aug 28, 2016 •
edited by larsbergstrom

This change is Reviewable
nox added 2 commits Aug 28, 2016
@nox
Remove features and lints that were removed with inline drop flags
54b8365
@nox
Implement ToJSValConvertible for NonZero<*mut JSObject>
Loading status checks…
4baa07b
@nox nox mentioned this pull request Aug 28, 2016
Merged
@Manishearth
Copy link
Member

Manishearth commented Aug 30, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2016

📌 Commit 4baa07b has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2016

⌛ Testing commit 4baa07b with merge f5444dd...
bors-servo added a commit that referenced this pull request Aug 30, 2016
@bors-servo
Auto merge of #299 - servo:nonzero, r=Manishearth
Loading status checks…
f5444dd 
Implement ToJSValConvertible for NonZero<*mut JSObject>

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/299)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2016

☀️ Test successful - status-appveyor, status-travis
@bors-servo bors-servo merged commit 4baa07b into master Aug 30, 2016
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the nonzero branch Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@nox @Manishearth @bors-servo
You can’t perform that action at this time.