Skip to content

/ rust-mozjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update etc/bindings.sh for the new bindgen flag format #300

Merged
merged 1 commit into from Aug 30, 2016
Merged

Update etc/bindings.sh for the new bindgen flag format #300

merged 1 commit into from Aug 30, 2016

Conversation

@fitzgen
Copy link
Member

fitzgen commented Aug 29, 2016 •
edited by larsbergstrom

r? @emilio

This change is Reviewable
@emilio
Copy link
Member

emilio commented Aug 30, 2016

I'd have expected you to need to put wrapper.h after everything else, but if not, r=me
@emilio
Copy link
Member

emilio commented Aug 30, 2016

@bors-servo: delegate+ (not sure if you have bors-superpowers)
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2016

✌️ @fitzgen can now approve this pull request
@fitzgen
Copy link
Member Author

fitzgen commented Aug 30, 2016

I'd have expected you to need to put wrapper.h after everything else, but if not, r=me

It is after all the normal flags, but before -- and the flags that get passed through to clang.
@emilio
Copy link
Member

emilio commented Aug 30, 2016

@fitzgen: Yeah, I mean, for the -x c++ -std=c++11 to be effective, I think you need to give the filename after it?

Anyway, I guess you've tested it, so feel free to invoke bors with r=emilio
@fitzgen
Update etc/bindings.sh for the new bindgen flag format
Loading status checks…
1e71c1e
@fitzgen fitzgen force-pushed the fitzgen:bindgen-flags-changed branch from e3cd9f2 to 1e71c1e Aug 30, 2016
@fitzgen
Copy link
Member Author

fitzgen commented Aug 30, 2016

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2016

📌 Commit 1e71c1e has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2016

⌛ Testing commit 1e71c1e with merge bbf907b...
bors-servo added a commit that referenced this pull request Aug 30, 2016
@bors-servo
Auto merge of #300 - fitzgen:bindgen-flags-changed, r=emilio
Loading status checks…
bbf907b 
Update etc/bindings.sh for the new bindgen flag format

r? @emilio

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/300)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2016

☀️ Test successful - status-appveyor, status-travis
@bors-servo bors-servo merged commit 1e71c1e into servo:master Aug 30, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@fitzgen @emilio @bors-servo
You can’t perform that action at this time.