Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd the `etc/bindings-all.py` script to orchestrate bindings generation #302
Conversation
etc/bindings-all.py
Outdated
| try: | ||
| run(["cargo", "build"] + extra_cargo_flags) | ||
| except subprocess.CalledProcessError: | ||
| # This is expected to initially fail because the bindings aren't up to |
This comment has been minimized.
This comment has been minimized.
Ms2ger
Sep 7, 2016
Collaborator
Can you try making this call cargo build -p mozjs_sys instead? r+ either way.
This comment has been minimized.
This comment has been minimized.
The `bindings-all.py` script will make sure that you don't accidentally try and use DEBUG bindings for a non-DEBUG build or vice-versa. It orchestrates all of building, regenerating and testing new SpiderMonkey bindings.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 9, 2016
Add the `etc/bindings-all.py` script to orchestrate bindings generation The `bindings-all.py` script will make sure that you don't accidentally try and use DEBUG bindings for a non-DEBUG build or vice-versa. It orchestrates all of building, regenerating and testing new SpiderMonkey bindings. Running this script on fedora regenerates the linux_64 bindings exactly as they are on the smup branch for me. I think this is a large usability improvement over what we do now. r? @Ms2ger @nox <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/302) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
to servo/mozjs
that referenced
this pull request
Sep 12, 2016
…, r=Ms2ger Update the upgrading instructions to use `bindings-all.py` instead of many manual steps Now that servo/rust-mozjs#302 landed. r? @Ms2ger <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/100) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fitzgen commentedSep 6, 2016
•
edited by larsbergstrom
The
bindings-all.pyscript will make sure that you don't accidentally try and use DEBUG bindings for a non-DEBUG build or vice-versa. It orchestrates all of building, regenerating and testing new SpiderMonkey bindings.Running this script on fedora regenerates the linux_64 bindings exactly as they are on the smup branch for me. I think this is a large usability improvement over what we do now.
r? @Ms2ger @nox
This change is