Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a ConversionResult::Failure when converting a non-iterable value to Vec. #306

Merged
merged 1 commit into from Sep 19, 2016

Conversation

@Ms2ger
Copy link
Collaborator

Ms2ger commented Sep 19, 2016

This change is Reviewable

@Ms2ger
Copy link
Collaborator Author

Ms2ger commented Sep 19, 2016

This is working towards servo/servo#13144.

@jdm
Copy link
Member

jdm commented Sep 19, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Sep 19, 2016

📌 Commit 3366341 has been approved by jdm

bors-servo added a commit that referenced this pull request Sep 19, 2016
Return a ConversionResult::Failure when converting a non-iterable value to Vec.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/306)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 19, 2016

Testing commit 3366341 with merge 4f25903...

@bors-servo
Copy link
Contributor

bors-servo commented Sep 19, 2016

☀️ Test successful - status-appveyor, status-travis

@bors-servo bors-servo merged commit 3366341 into master Sep 19, 2016
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the vec-convert branch Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.