Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHandle panics. #309
Merged
Handle panics. #309
+87
−0
Conversation
| Ok(result) => result, | ||
| Err(error) => { | ||
| PANIC_RESULT.with(|result| { | ||
| assert!(result.borrow().is_none()); |
This comment has been minimized.
This comment has been minimized.
jdm
Oct 25, 2016
Member
When we hit this assertion in servo/servo#13635 we get no information about either the existing stored panic or the new one. Can we improve that somehow?
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 14, 2016
Handle panics. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/309) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ms2ger commentedOct 25, 2016
•
edited by larsbergstrom
This change is