Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code involving empty type references #311

Merged
merged 1 commit into from Nov 2, 2016

Conversation

@DemiMarie
Copy link
Contributor

DemiMarie commented Nov 2, 2016

by changing it to use pointers instead.

Fixes #311


This change is Reviewable

by changing it to use pointers instead.

Fixes #311
@DemiMarie DemiMarie force-pushed the DemiMarie:no-empty-type-refs branch from 643dcad to 1ae01cc Nov 2, 2016
@Ms2ger
Copy link
Collaborator

Ms2ger commented Nov 2, 2016

@bors-servo r+

Thanks!

@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2016

📌 Commit 1ae01cc has been approved by Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2016

Testing commit 1ae01cc with merge 14cd66c...

bors-servo added a commit that referenced this pull request Nov 2, 2016
Fix code involving empty type references

by changing it to use pointers instead.

Fixes #311

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/311)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2016

☀️ Test successful - status-appveyor, status-travis

@bors-servo bors-servo merged commit 1ae01cc into servo:master Nov 2, 2016
2 of 3 checks passed
2 of 3 checks passed
code-review/reviewable 3 files left
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
tschneidereit pushed a commit to tschneidereit/rust-mozjs that referenced this pull request Aug 26, 2017
by changing it to use pointers instead.

Fixes servo#311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.