Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement FromJSValConvertible for *mut JSObject #321
Conversation
|
Doesn't compile |
|
Uhh right, stupid me. |
541b7e2
to
24e1a18
|
These implementations crash if handed the wrong type of value. Is that intentional? |
|
I essentially copied the implementation from JSVal. Shall I instead check that it is an object first, and if not, return an Err(()) or a ConversionResult::Failure? |
|
Let's take a step back. Why did you make this PR? |
|
MessagePort contains a WebIDL method that looks like this:
And so CodegenRust.py is trying to convert a JS HandleValue to a JS object, which currently doesn't exist in rust-mozjs bindings. |
|
Given that this is only needed because of codegen for a feature we don't support yet (transferrable objects), I propose we use |
KiChjang commentedDec 12, 2016
•
edited by larsbergstrom
r? @Ms2ger or @nox
This change is