Skip to content

/ rust-mozjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various GC improvements. #324

Merged
merged 5 commits into from Jan 12, 2017
Merged

Various GC improvements. #324

merged 5 commits into from Jan 12, 2017
+49 −40

Conversation

@Ms2ger
Copy link
Collaborator

Ms2ger commented Jan 12, 2017 •
edited by larsbergstrom

This change is Reviewable
Ms2ger added 5 commits Jan 12, 2017
@Ms2ger
Remove the type parameter from GCMethods.
88d9ce4 
Fixes #256.
@Ms2ger
Disallow constructing an unrooted Rooted with a value.
00387d5 
This should make it harder to use Rooted in an unsound way
(when not using the rooted!() macro).
@Ms2ger
Consistently apply the same bounds to RootedGuard's type parameter.
bd8b76b
@Ms2ger
Clear the value of a Rooted when the RootedGuard goes out of scope.
Loading status checks…
557a1ef 
This ensures no unrooted values linger in the Rooted when it is no longer
rooted.

It should be impossible to access the value after that, but Handles currently
lack the lifetime to prevent that (#153).
@Ms2ger
Simplify add_to_root_stack and remove_from_root_stack.
Loading status checks…
c87c208
@jdm
Copy link
Member

jdm commented Jan 12, 2017

These are worthwhile improvements. R=me if Travis is green.
@Ms2ger
Copy link
Collaborator Author

Ms2ger commented Jan 12, 2017

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jan 12, 2017

📌 Commit c87c208 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jan 12, 2017

⌛ Testing commit c87c208 with merge d800d43...
bors-servo added a commit that referenced this pull request Jan 12, 2017
@bors-servo
Auto merge of #324 - servo:gc, r=jdm
Loading status checks…
d800d43 
Various GC improvements.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/324)
<!-- Reviewable:end -->
@nox
Copy link
Member

nox commented Jan 12, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 12, 2017

💡 This pull request was already approved, no need to approve it again.

  • This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 12, 2017

📌 Commit c87c208 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Jan 12, 2017

☀️ Test successful - status-appveyor, status-travis
@bors-servo bors-servo merged commit c87c208 into master Jan 12, 2017
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the gc branch Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Ms2ger @jdm @bors-servo @nox
You can’t perform that action at this time.