Skip to content

/ rust-mozjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various GC improvements. #324

Merged
merged 5 commits into from Jan 12, 2017
Merged

Various GC improvements. #324

merged 5 commits into from Jan 12, 2017
+49 −40

Commits on Jan 12, 2017

  1. Remove the type parameter from GCMethods. 

    Fixes #256.
    @Ms2ger
    Ms2ger committed Jan 12, 2017
    88d9ce4

  2. Disallow constructing an unrooted Rooted with a value. 

    This should make it harder to use Rooted in an unsound way
(when not using the rooted!() macro).
    @Ms2ger
    Ms2ger committed Jan 12, 2017
    00387d5

  3. Consistently apply the same bounds to RootedGuard's type parameter.

    @Ms2ger
    Ms2ger committed Jan 12, 2017
    bd8b76b

  4. Clear the value of a Rooted when the RootedGuard goes out of scope. 

    This ensures no unrooted values linger in the Rooted when it is no longer
rooted.

It should be impossible to access the value after that, but Handles currently
lack the lifetime to prevent that (#153).
    @Ms2ger
    Ms2ger committed Jan 12, 2017
    Loading status checks…
    557a1ef

  5. Simplify add_to_root_stack and remove_from_root_stack.

    @Ms2ger
    Ms2ger committed Jan 12, 2017
    Loading status checks…
    c87c208
You can’t perform that action at this time.