Skip to content

/ rust-mozjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Runtime::get() works during the final GC under JS_DestroyRuntime. #327

Merged
merged 2 commits into from Jan 18, 2017
Merged

Ensure Runtime::get() works during the final GC under JS_DestroyRuntime. #327

merged 2 commits into from Jan 18, 2017

Conversation

@Ms2ger
Copy link
Collaborator

Ms2ger commented Jan 18, 2017 •
edited by larsbergstrom

This change is Reviewable
@Ms2ger
Ensure Runtime::get() works during the final GC under JS_DestroyRuntime.
Loading status checks…
36c5d5b
@jdm
Copy link
Member

jdm commented Jan 18, 2017

A test verifying this behaviour would be ideal, whether in this repository of as a web-platform-test.
@Ms2ger
Add test.
Loading status checks…
564eb8f
@jdm
Copy link
Member

jdm commented Jan 18, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 18, 2017

📌 Commit 564eb8f has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jan 18, 2017

⌛ Testing commit 564eb8f with merge 71acb0c...
bors-servo added a commit that referenced this pull request Jan 18, 2017
@bors-servo
Auto merge of #327 - servo:runtime-get-order, r=jdm
Loading status checks…
71acb0c 
Ensure Runtime::get() works during the final GC under JS_DestroyRuntime.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/327)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 18, 2017

☀️ Test successful - status-appveyor, status-travis
@bors-servo bors-servo merged commit 564eb8f into master Jan 18, 2017
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the runtime-get-order branch Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Ms2ger @jdm @bors-servo
You can’t perform that action at this time.