Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upProtect TypedArray::from method against null pointers #334
Conversation
|
One nit, the rest looks great, thanks for working on this! :) |
src/typedarray.rs
Outdated
| @@ -70,6 +70,9 @@ impl<'a, T: TypedArrayElement> TypedArray<'a, T> { | |||
| root: &'a mut Rooted<*mut JSObject>, | |||
| object: *mut JSObject) | |||
| -> Result<Self, ()> { | |||
| if object == ptr::null_mut() { | |||
This comment has been minimized.
This comment has been minimized.
|
Perfect! Please squash the commit (bors doesn't do that automatically), and this is good to merge :) |
|
@bors-servo r=emilio |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 6, 2017
Protect TypedArray::from method against null pointers Fixes #332. Also added a test as described in the issue. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/334) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
zakorgy commentedFeb 6, 2017
•
edited by larsbergstrom
Fixes #332. Also added a test as described in the issue.
This change is