Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArrayBufferView convenience method for typed arrays #340

Merged
merged 2 commits into from Feb 17, 2017
Merged

Conversation

@bd339
Copy link
Contributor

bd339 commented Feb 15, 2017

Fixes #331 .


This change is Reviewable

bd339 added 2 commits Feb 15, 2017
Implement a get_array_type method for ArrayBufferView. It is a convenience method which calls the unsafe JS_GetArrayBufferViewType method.
@jdm
Copy link
Member

jdm commented Feb 16, 2017

@bors-servo: r+
Thanks for fixing this!

@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2017

📌 Commit 451952e has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2017

Testing commit 451952e with merge 101c6b6...

bors-servo added a commit that referenced this pull request Feb 16, 2017
ArrayBufferView convenience method for typed arrays

Fixes #331 .

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/340)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 17, 2017

💔 Test failed - status-travis

@bors-servo
Copy link
Contributor

bors-servo commented Feb 17, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: jdm
Pushing 101c6b6 to master...

@bors-servo bors-servo merged commit 451952e into servo:master Feb 17, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@cbrewster cbrewster mentioned this pull request Feb 21, 2017
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.