Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rustc 1.19.0-nightly (ced823e26 2017-05-07) #358

Merged
merged 1 commit into from May 7, 2017
Merged

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented May 7, 2017

This change is Reviewable

@nox
Copy link
Member

nox commented May 7, 2017

@bors-servo
Copy link
Contributor

bors-servo commented May 7, 2017

📌 Commit 61dc5c9 has been approved by nox

@bors-servo
Copy link
Contributor

bors-servo commented May 7, 2017

Testing commit 61dc5c9 with merge a88d705...

bors-servo added a commit that referenced this pull request May 7, 2017
Upgrade to rustc 1.19.0-nightly (ced823e26 2017-05-07)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/358)
<!-- Reviewable:end -->
@SimonSapin
Copy link
Member Author

SimonSapin commented May 7, 2017

Travis fails because rust-lang/rust#41064 hasn’t reached Nigthly yet. Tested locally with rustc 1.19.0-nightly (ced823e26 2017-05-07).

cargo test --features debugmozjs shows:

WARNING: YOU ARE LEAKING THE WORLD (at least one JSRuntime and everything alive inside it, that is) AT JS_ShutDown TIME. FIX THIS!

… but it already did in https://travis-ci.org/servo/rust-mozjs/jobs/225720367.

@bors-servo
Copy link
Contributor

bors-servo commented May 7, 2017

💔 Test failed - status-travis

@SimonSapin SimonSapin merged commit 08af365 into master May 7, 2017
0 of 5 checks passed
0 of 5 checks passed
continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
homu Test failed
Details
@SimonSapin SimonSapin deleted the rustup branch May 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.