Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused `link_args` feature flag #370

Merged
merged 1 commit into from Oct 3, 2017
Merged

Remove unused `link_args` feature flag #370

merged 1 commit into from Oct 3, 2017

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Oct 3, 2017

We now print cargo:rustc-link-… from build.rs instead.


This change is Reviewable

We now print `cargo:rustc-link-…` from `build.rs` instead.
@nox
Copy link
Member

nox commented Oct 3, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

📌 Commit 66792ed has been approved by nox

@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

Testing commit 66792ed with merge 75a9550...

bors-servo added a commit that referenced this pull request Oct 3, 2017
Remove unused `link_args` feature flag

We now print `cargo:rustc-link-…` from `build.rs` instead.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/370)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

💔 Test failed - status-travis

@jdm
Copy link
Member

jdm commented Oct 3, 2017

#371 should fix the travis problems.

@jdm
Copy link
Member

jdm commented Oct 3, 2017

@bors-servo: retry

@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

Testing commit 66792ed with merge 2da7779...

bors-servo added a commit that referenced this pull request Oct 3, 2017
Remove unused `link_args` feature flag

We now print `cargo:rustc-link-…` from `build.rs` instead.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/370)
<!-- Reviewable:end -->
@SimonSapin
Copy link
Member Author

SimonSapin commented Oct 3, 2017

Thanks @jdm

@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: nox
Pushing 2da7779 to master...

@bors-servo bors-servo merged commit 66792ed into master Oct 3, 2017
3 of 5 checks passed
3 of 5 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the link branch Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.