Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `heapsize` dependency. #375

Merged
merged 1 commit into from Oct 19, 2017
Merged

Conversation

@nnethercote
Copy link
Contributor

nnethercote commented Oct 18, 2017

The heapsize crate is being deprecated in favour of the
malloc_size_of crate within Servo.


This change is Reviewable

The `heapsize` crate is being deprecated in favour of the
`malloc_size_of` crate within Servo.
@nnethercote
Copy link
Contributor Author

nnethercote commented Oct 18, 2017

I incremented the version number to 0.1.7; not sure if that's necessary.

I ran cargo build and cargo test and all the tests passed.

@jdm
Copy link
Member

jdm commented Oct 19, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Oct 19, 2017

📌 Commit 3219cde has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Oct 19, 2017

Testing commit 3219cde with merge 1dc8aab...

bors-servo added a commit that referenced this pull request Oct 19, 2017
Remove `heapsize` dependency.

The `heapsize` crate is being deprecated in favour of the
`malloc_size_of` crate within Servo.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/375)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 19, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: jdm
Pushing 1dc8aab to master...

@bors-servo bors-servo merged commit 3219cde into servo:master Oct 19, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nnethercote nnethercote deleted the nnethercote:rm-heapsize branch Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.