Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove FromJSValConvertible implementation for HandleValue #388
Conversation
|
I'm going to hold off on merging this until the Servo PR is ready to merge. |
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 3, 2018
Remove FromJSValConvertible implementation for HandleValue Needed for servo/servo#19644. Removes FromJSValConvertible implementations for `HandleValue`, so `Vec<HandleValue>` conversion is impossible. Also adds the implementation for `*mut JSObject` so the `sequence<object>` -> `CustomAutoRooterGuard<Vec<*mut JSObject>>` conversion works. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/388) <!-- Reviewable:end -->
|
@bors-servo: r- |
|
Bumped to 0.1.10. |
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 3, 2018
Remove FromJSValConvertible implementation for HandleValue Needed for servo/servo#19644. Removes FromJSValConvertible implementations for `HandleValue`, so `Vec<HandleValue>` conversion is impossible. Also adds the implementation for `*mut JSObject` so the `sequence<object>` -> `CustomAutoRooterGuard<Vec<*mut JSObject>>` conversion works. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/388) <!-- Reviewable:end -->
|
|
|
The appveyor problem will go away once #389 is merged. |
|
@bors-servo: retry |
bors-servo
added a commit
that referenced
this pull request
Jan 5, 2018
Remove FromJSValConvertible implementation for HandleValue Needed for servo/servo#19644. Removes FromJSValConvertible implementations for `HandleValue`, so `Vec<HandleValue>` conversion is impossible. Also adds the implementation for `*mut JSObject` so the `sequence<object>` -> `CustomAutoRooterGuard<Vec<*mut JSObject>>` conversion works. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/388) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Xanewok commentedDec 25, 2017
•
edited by larsbergstrom
Needed for servo/servo#19644.
Removes FromJSValConvertible implementations for
HandleValue, soVec<HandleValue>conversion is impossible.Also adds the implementation for
*mut JSObjectso thesequence<object>->CustomAutoRooterGuard<Vec<*mut JSObject>>conversion works.This change is