Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd TypedArray API using Heap-wrapped objects #397
Merged
+117
−51
Conversation
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 13, 2018
Add TypedArray API using Heap-wrapped objects Needed for servo/servo#20267. This changes TypedArray wrapper type to only contain typed array-related logic and not handle rooting, and introduces 2 different possible storage options for wrapped objects - `*mut JSObject`, can be rooted on stack (e.g. using CustomAutoRooter) - `Box<Heap<*mut JSObject>>`, can be rooted on heap with `JSTraceable` trait (implemented on Servo side) Since the API changes are breaking, I bumped minor version so that Servo will not break when updating. r? @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/397) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Xanewok commentedMar 13, 2018
•
edited by larsbergstrom
Needed for servo/servo#20267.
This changes TypedArray wrapper type to only contain typed array-related logic and not handle rooting, and introduces 2 different possible storage options for wrapped objects
*mut JSObject, can be rooted on stack (e.g. using CustomAutoRooter)Box<Heap<*mut JSObject>>, can be rooted on heap withJSTraceabletrait (implemented on Servo side)Since the API changes are breaking, I bumped minor version so that Servo will not break when updating.
r? @jdm
This change is