Skip to content

/ rust-mozjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ToJSValConvertible for [T] #401

Merged
merged 1 commit into from Mar 22, 2018
Merged

Implement ToJSValConvertible for [T] #401

merged 1 commit into from Mar 22, 2018

Conversation

@nox
Copy link
Member

nox commented Mar 22, 2018 •
edited by larsbergstrom

This change is Reviewable
@nox
Implement ToJSValConvertible for [T]
Loading status checks…
8ae8f62
@jdm
Copy link
Member

jdm commented Mar 22, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 22, 2018

📌 Commit 8ae8f62 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Mar 22, 2018

⌛ Testing commit 8ae8f62 with merge e14d4c6...
bors-servo added a commit that referenced this pull request Mar 22, 2018
@bors-servo
Auto merge of #401 - servo:convert-slice, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e14d4c6 
Implement ToJSValConvertible for [T]

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/401)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 22, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: jdm
Pushing e14d4c6 to master...
@bors-servo bors-servo merged commit 8ae8f62 into master Mar 22, 2018
5 checks passed
5 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
homu Test successful
Details
@nox nox deleted the convert-slice branch Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@nox @jdm @bors-servo
You can’t perform that action at this time.