Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded Default implementation for PropertyDescriptor #407
Conversation
|
I would just add this to rust.rs. Right now this code won't be compiled unless lib.rs is modified to include the new module. |
|
Done. So stupid of me, I forgot to update lib.rs |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 24, 2018
Added Default implementation for PropertyDescriptor It is needed for servo to be able to use `JS_GetOwnPropertyDescriptorById` method as it needs `MutableHandle<PropertyDescriptor>` as output parameter. To get the `MutableHandle` one should do sth like `rooted!(in(cx) let mut desc = dummyPropertyDescriptor)` and then `desc.handle_mut()`. Now there are no easy ways to get `dummyPropertyDescriptor`. I am not sure if it is the proper way. AFAIK the jsapi_* files are automatically generated they shouldn't be modified and I don't know how to make bindgen generate `derive(Default)` for PropertyDescriptor <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/407) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
taki-jaro commentedMar 24, 2018
•
edited by larsbergstrom
It is needed for servo to be able to use
JS_GetOwnPropertyDescriptorByIdmethod as it needsMutableHandle<PropertyDescriptor>as output parameter. To get theMutableHandleone should do sth likerooted!(in(cx) let mut desc = dummyPropertyDescriptor)and thendesc.handle_mut(). Now there are no easy ways to getdummyPropertyDescriptor.I am not sure if it is the proper way. AFAIK the jsapi_* files are automatically generated they shouldn't be modified and I don't know how to make bindgen generate
derive(Default)for PropertyDescriptorThis change is