Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTake scripts as ~str to support non-ASCII string literals etc. #41
Conversation
The ASCII-based JS_EvaluateScript converts to UTF-16 internally, so this shouldn't be fundamentally worse (but I haven't benchmarked the two conversion routines or anything).
This comment has been minimized.
This comment has been minimized.
metajack
commented on 7372f6b
Oct 16, 2013
|
r+ |
metajack
added a commit
that referenced
this pull request
Oct 16, 2013
Take scripts as ~str to support non-ASCII string literals etc.
tschneidereit
pushed a commit
to tschneidereit/rust-mozjs
that referenced
this pull request
Aug 26, 2017
Fix build in Raspberry Pi2. r=mbrubeck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kmcallister commentedOct 16, 2013
The ASCII-based
JS_EvaluateScriptconverts to UTF-16 internally, so this shouldn't be fundamentally worse (but I haven't benchmarked the two conversion routines or anything).