Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate a second set of borrowing wrappers #422
Merged
Conversation
|
Can you describe the change in the commit message, please? |
Our current wrappers held in rust::wrappers accept the Handles by consume/Copy. This was introduced in #393 to make it feasible to migrate the API calls on the Servo side in finite time. This, in particular, requires unsafe code in the implementation of MutableHandle. This change introduces a second set of wrappers, which will now borrow MutableHandles instead of relying on impl Copy for MutableHandle. The Servo code should gradually move to the new wrappers, rust::jsapi_wrapped, so that we can eventually remove rust::wrappers.
|
@nox done |
|
@bors-servo r+ Thanks for your work and patience, sorry for taking so long to review this. |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 17, 2018
Create a second set of borrowing wrappers As agreed here: https://mozilla.logbot.info/servo/20180326#c14521098-c14521118 https://mozilla.logbot.info/servo/20180405#c14564933 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/422) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
marmistrz commentedApr 11, 2018
•
edited by larsbergstrom
As agreed here:
https://mozilla.logbot.info/servo/20180326#c14521098-c14521118
https://mozilla.logbot.info/servo/20180405#c14564933
This change is