Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require C++14 #423

Closed
wants to merge 2 commits into from
Closed

Require C++14 #423

wants to merge 2 commits into from

Conversation

@vyv03354
Copy link

vyv03354 commented Apr 11, 2018

Currently C++14 features are unavailable due to explicit -std=c++11 switch.
See also https://bugzilla.mozilla.org/show_bug.cgi?id=1451931


This change is Reviewable

vyv03354 added 2 commits Apr 11, 2018
Currently C++14 features are unavailable due to explicit -std=c++11 switch.
See also https://bugzilla.mozilla.org/show_bug.cgi?id=1451931
@bors-servo
Copy link
Contributor

bors-servo commented May 2, 2018

The latest upstream changes (presumably #424) made this pull request unmergeable. Please resolve the merge conflicts.

@KiChjang
Copy link
Member

KiChjang commented May 2, 2018

Given #424, we're not using cmake anymore, and instead we're opting for using the cc crate.

@KiChjang KiChjang closed this May 2, 2018
@jdm
Copy link
Member

jdm commented May 2, 2018

@vyv03354 What was the motivation for this change? What C++ usage was prevented?

@jdm
Copy link
Member

jdm commented May 2, 2018

Oh, this was literally just upstreaming the change from https://bugzilla.mozilla.org/show_bug.cgi?id=1451931?

@vyv03354 vyv03354 deleted the vyv03354:patch-1 branch May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.