Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove cmake usage. #424
Merged
Remove cmake usage. #424
Conversation
|
r? @asajeffrey |
|
Just some minor nits, otherwise looks good! |
build.rs
Outdated
| let mut build = cc::Build::new(); | ||
| build | ||
| .file("src/jsglue.cpp") | ||
| .include(&format!("{}/dist/include", env::var("DEP_MOZJS_OUTDIR").unwrap())); |
This comment has been minimized.
This comment has been minimized.
build.rs
Outdated
| build.flag_if_supported("-Wno-c++0x-extensions"); | ||
| build.flag_if_supported("-Wno-return-type-c-linkage"); | ||
| build.flag_if_supported("-Wno-invalid-offsetof"); | ||
|
|
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r=asajeffrey |
|
|
bors-servo
added a commit
that referenced
this pull request
May 2, 2018
Remove cmake usage. This change addresses https://lists.mozilla.org/pipermail/dev-platform/2018-April/021589.html but would require uplifting to mozilla-central for their build to benefit from it. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/424) <!-- Reviewable:end -->
|
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedMay 1, 2018
•
edited by larsbergstrom
This change addresses https://lists.mozilla.org/pipermail/dev-platform/2018-April/021589.html but would require uplifting to mozilla-central for their build to benefit from it.
This change is