Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGet the mozjs crate to work with the mozjs_sys which uses bindgen #425
Conversation
asajeffrey
changed the title
|
cc @jdm |
|
This can land once servo/mozjs#134 does. |
|
Oh I guess it makes sense to hold off for servo/mozjs#135, since then we don't have to check in a patch entry in Cargo.toml. |
asajeffrey
changed the title
|
https://crates.io/crates/mozjs_sys/0.51.0 is published, so we can land this. @bors-servo r=jdm |
|
|
bors-servo
added a commit
that referenced
this pull request
May 23, 2018
Get the mozjs crate to work with the mozjs_sys which uses bindgen This is the matching PR to servo/mozjs#134 which runs bindgen on spidermonkey to produce Rust bindings. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/425) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
to servo/servo
that referenced
this pull request
May 23, 2018
Get the mozjs crate to work with the mozjs_sys which uses bindgen <!-- Please describe your changes on the following line: --> This is the matching PR to servo/mozjs#134 and servo/rust-mozjs#425 which runs bindgen on spidermonkey to produce Rust bindings. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because current tests should catch failures <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20793) <!-- Reviewable:end -->
bors-servo
added a commit
to servo/servo
that referenced
this pull request
May 24, 2018
Get the mozjs crate to work with the mozjs_sys which uses bindgen <!-- Please describe your changes on the following line: --> This is the matching PR to servo/mozjs#134 and servo/rust-mozjs#425 which runs bindgen on spidermonkey to produce Rust bindings. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because current tests should catch failures <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20793) <!-- Reviewable:end -->
bors-servo
added a commit
to servo/servo
that referenced
this pull request
May 24, 2018
Get the mozjs crate to work with the mozjs_sys which uses bindgen <!-- Please describe your changes on the following line: --> This is the matching PR to servo/mozjs#134 and servo/rust-mozjs#425 which runs bindgen on spidermonkey to produce Rust bindings. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because current tests should catch failures <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20793) <!-- Reviewable:end -->
bors-servo
added a commit
to servo/servo
that referenced
this pull request
May 25, 2018
Get the mozjs crate to work with the mozjs_sys which uses bindgen <!-- Please describe your changes on the following line: --> This is the matching PR to servo/mozjs#134 and servo/rust-mozjs#425 which runs bindgen on spidermonkey to produce Rust bindings. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because current tests should catch failures <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20793) <!-- Reviewable:end -->
bors-servo
added a commit
to servo/servo
that referenced
this pull request
May 25, 2018
Get the mozjs crate to work with the mozjs_sys which uses bindgen <!-- Please describe your changes on the following line: --> This is the matching PR to servo/mozjs#134 and servo/rust-mozjs#425 which runs bindgen on spidermonkey to produce Rust bindings. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because current tests should catch failures <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20793) <!-- Reviewable:end -->
bors-servo
added a commit
to servo/servo
that referenced
this pull request
May 29, 2018
Get the mozjs crate to work with the mozjs_sys which uses bindgen <!-- Please describe your changes on the following line: --> This is the matching PR to servo/mozjs#134 and servo/rust-mozjs#425 which runs bindgen on spidermonkey to produce Rust bindings. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because current tests should catch failures <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20793) <!-- Reviewable:end -->
bors-servo
added a commit
to servo/servo
that referenced
this pull request
May 29, 2018
Get the mozjs crate to work with the mozjs_sys which uses bindgen <!-- Please describe your changes on the following line: --> This is the matching PR to servo/mozjs#134 and servo/rust-mozjs#425 which runs bindgen on spidermonkey to produce Rust bindings. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because current tests should catch failures <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20793) <!-- Reviewable:end -->
bors-servo
added a commit
to servo/servo
that referenced
this pull request
May 29, 2018
Get the mozjs crate to work with the mozjs_sys which uses bindgen <!-- Please describe your changes on the following line: --> This is the matching PR to servo/mozjs#134 and servo/rust-mozjs#425 which runs bindgen on spidermonkey to produce Rust bindings. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because current tests should catch failures <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20793) <!-- Reviewable:end -->
bors-servo
added a commit
to servo/servo
that referenced
this pull request
May 30, 2018
Get the mozjs crate to work with the mozjs_sys which uses bindgen <!-- Please describe your changes on the following line: --> This is the matching PR to servo/mozjs#134 and servo/rust-mozjs#425 which runs bindgen on spidermonkey to produce Rust bindings. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because current tests should catch failures <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20793) <!-- Reviewable:end -->
bors-servo
added a commit
to servo/servo
that referenced
this pull request
May 30, 2018
Get the mozjs crate to work with the mozjs_sys which uses bindgen <!-- Please describe your changes on the following line: --> This is the matching PR to servo/mozjs#134 and servo/rust-mozjs#425 which runs bindgen on spidermonkey to produce Rust bindings. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because current tests should catch failures <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20793) <!-- Reviewable:end -->
bors-servo
added a commit
to servo/servo
that referenced
this pull request
May 30, 2018
Get the mozjs crate to work with the mozjs_sys which uses bindgen <!-- Please describe your changes on the following line: --> This is the matching PR to servo/mozjs#134 and servo/rust-mozjs#425 which runs bindgen on spidermonkey to produce Rust bindings. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because current tests should catch failures <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20793) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedMay 16, 2018
•
edited by larsbergstrom
This is the matching PR to servo/mozjs#134 which runs bindgen on spidermonkey to produce Rust bindings.
This change is