Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the mozjs crate to work with the mozjs_sys which uses bindgen #425

Merged
merged 1 commit into from May 23, 2018

Conversation

Projects
None yet
3 participants
@asajeffrey
Copy link
Member

commented May 16, 2018

This is the matching PR to servo/mozjs#134 which runs bindgen on spidermonkey to produce Rust bindings.


This change is Reviewable

@asajeffrey asajeffrey changed the title [WIP] Got the mozjs crate to work with the mozjs_sys which uses bindgen [WIP] Get the mozjs crate to work with the mozjs_sys which uses bindgen May 16, 2018

@asajeffrey

This comment has been minimized.

Copy link
Member Author

commented May 16, 2018

cc @jdm

@asajeffrey asajeffrey force-pushed the asajeffrey:bindgenup branch from 4e81042 to a525d2b May 16, 2018

@jdm

jdm approved these changes May 22, 2018

@asajeffrey

This comment has been minimized.

Copy link
Member Author

commented May 22, 2018

This can land once servo/mozjs#134 does.

@asajeffrey

This comment has been minimized.

Copy link
Member Author

commented May 22, 2018

Oh I guess it makes sense to hold off for servo/mozjs#135, since then we don't have to check in a patch entry in Cargo.toml.

@asajeffrey asajeffrey force-pushed the asajeffrey:bindgenup branch from a525d2b to 5f25fd6 May 23, 2018

@asajeffrey asajeffrey changed the title [WIP] Get the mozjs crate to work with the mozjs_sys which uses bindgen Get the mozjs crate to work with the mozjs_sys which uses bindgen May 23, 2018

@asajeffrey

This comment has been minimized.

Copy link
Member Author

commented May 23, 2018

https://crates.io/crates/mozjs_sys/0.51.0 is published, so we can land this.

@bors-servo r=jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 23, 2018

📌 Commit 5f25fd6 has been approved by jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 23, 2018

⌛️ Testing commit 5f25fd6 with merge 6d4c8b9...

bors-servo added a commit that referenced this pull request May 23, 2018

Auto merge of #425 - asajeffrey:bindgenup, r=jdm
Get the mozjs crate to work with the mozjs_sys which uses bindgen

This is the matching PR to servo/mozjs#134 which runs bindgen on spidermonkey to produce Rust bindings.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/425)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 23, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: jdm
Pushing 6d4c8b9 to master...

@bors-servo bors-servo merged commit 5f25fd6 into servo:master May 23, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

bors-servo added a commit to servo/servo that referenced this pull request May 23, 2018

Auto merge of #20793 - asajeffrey:bindgenup, r=jdm
Get the mozjs crate to work with the mozjs_sys which uses bindgen

<!-- Please describe your changes on the following line: -->

This is the matching PR to servo/mozjs#134 and servo/rust-mozjs#425 which runs bindgen on spidermonkey to produce Rust bindings.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because current tests should catch failures

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20793)
<!-- Reviewable:end -->

bors-servo added a commit to servo/servo that referenced this pull request May 24, 2018

Auto merge of #20793 - asajeffrey:bindgenup, r=jdm
Get the mozjs crate to work with the mozjs_sys which uses bindgen

<!-- Please describe your changes on the following line: -->

This is the matching PR to servo/mozjs#134 and servo/rust-mozjs#425 which runs bindgen on spidermonkey to produce Rust bindings.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because current tests should catch failures

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20793)
<!-- Reviewable:end -->

bors-servo added a commit to servo/servo that referenced this pull request May 24, 2018

Auto merge of #20793 - asajeffrey:bindgenup, r=<try>
Get the mozjs crate to work with the mozjs_sys which uses bindgen

<!-- Please describe your changes on the following line: -->

This is the matching PR to servo/mozjs#134 and servo/rust-mozjs#425 which runs bindgen on spidermonkey to produce Rust bindings.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because current tests should catch failures

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20793)
<!-- Reviewable:end -->

bors-servo added a commit to servo/servo that referenced this pull request May 25, 2018

Auto merge of #20793 - asajeffrey:bindgenup, r=<try>
Get the mozjs crate to work with the mozjs_sys which uses bindgen

<!-- Please describe your changes on the following line: -->

This is the matching PR to servo/mozjs#134 and servo/rust-mozjs#425 which runs bindgen on spidermonkey to produce Rust bindings.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because current tests should catch failures

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20793)
<!-- Reviewable:end -->

bors-servo added a commit to servo/servo that referenced this pull request May 25, 2018

Auto merge of #20793 - asajeffrey:bindgenup, r=<try>
Get the mozjs crate to work with the mozjs_sys which uses bindgen

<!-- Please describe your changes on the following line: -->

This is the matching PR to servo/mozjs#134 and servo/rust-mozjs#425 which runs bindgen on spidermonkey to produce Rust bindings.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because current tests should catch failures

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20793)
<!-- Reviewable:end -->

bors-servo added a commit to servo/servo that referenced this pull request May 29, 2018

Auto merge of #20793 - asajeffrey:bindgenup, r=<try>
Get the mozjs crate to work with the mozjs_sys which uses bindgen

<!-- Please describe your changes on the following line: -->

This is the matching PR to servo/mozjs#134 and servo/rust-mozjs#425 which runs bindgen on spidermonkey to produce Rust bindings.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because current tests should catch failures

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20793)
<!-- Reviewable:end -->

bors-servo added a commit to servo/servo that referenced this pull request May 29, 2018

Auto merge of #20793 - asajeffrey:bindgenup, r=<try>
Get the mozjs crate to work with the mozjs_sys which uses bindgen

<!-- Please describe your changes on the following line: -->

This is the matching PR to servo/mozjs#134 and servo/rust-mozjs#425 which runs bindgen on spidermonkey to produce Rust bindings.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because current tests should catch failures

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20793)
<!-- Reviewable:end -->

bors-servo added a commit to servo/servo that referenced this pull request May 29, 2018

Auto merge of #20793 - asajeffrey:bindgenup, r=<try>
Get the mozjs crate to work with the mozjs_sys which uses bindgen

<!-- Please describe your changes on the following line: -->

This is the matching PR to servo/mozjs#134 and servo/rust-mozjs#425 which runs bindgen on spidermonkey to produce Rust bindings.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because current tests should catch failures

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20793)
<!-- Reviewable:end -->

bors-servo added a commit to servo/servo that referenced this pull request May 30, 2018

Auto merge of #20793 - asajeffrey:bindgenup, r=<try>
Get the mozjs crate to work with the mozjs_sys which uses bindgen

<!-- Please describe your changes on the following line: -->

This is the matching PR to servo/mozjs#134 and servo/rust-mozjs#425 which runs bindgen on spidermonkey to produce Rust bindings.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because current tests should catch failures

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20793)
<!-- Reviewable:end -->

bors-servo added a commit to servo/servo that referenced this pull request May 30, 2018

Auto merge of #20793 - asajeffrey:bindgenup, r=jdm
Get the mozjs crate to work with the mozjs_sys which uses bindgen

<!-- Please describe your changes on the following line: -->

This is the matching PR to servo/mozjs#134 and servo/rust-mozjs#425 which runs bindgen on spidermonkey to produce Rust bindings.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because current tests should catch failures

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20793)
<!-- Reviewable:end -->

bors-servo added a commit to servo/servo that referenced this pull request May 30, 2018

Auto merge of #20793 - asajeffrey:bindgenup, r=jdm
Get the mozjs crate to work with the mozjs_sys which uses bindgen

<!-- Please describe your changes on the following line: -->

This is the matching PR to servo/mozjs#134 and servo/rust-mozjs#425 which runs bindgen on spidermonkey to produce Rust bindings.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because current tests should catch failures

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20793)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.