Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd function to tell whether a TypedArray underlying buffer is shared #438
Conversation
|
r? @jdm |
src/typedarray.rs
Outdated
| /// | ||
| /// Return a boolean flag which denotes whether the underlying buffer | ||
| /// is a SharedArrayBuffer. | ||
| pub unsafe fn is_shared(&self) -> bool { |
This comment has been minimized.
This comment has been minimized.
|
r=me with the unsafe removed. |
|
I knew I added it for a reason :)
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 6, 2018
Add function to tell whether a TypedArray underlying buffer is shared <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/438) <!-- Reviewable:end -->
|
|
|
@jdm could you publish a new release with this change, please? |
|
Done. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedSep 6, 2018
•
edited by larsbergstrom
This change is