New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around inconsistent padding from different LLVM versions. #440

Merged
merged 2 commits into from Sep 24, 2018

Conversation

Projects
None yet
2 participants
@jdm
Member

jdm commented Sep 24, 2018

This allows building with LLVM 4 or 6 and unbreaks my mac cross-compilation.


This change is Reviewable

@jdm jdm force-pushed the macfix branch from 96b52df to 8f50cb1 Sep 24, 2018

@jdm

This comment has been minimized.

Member

jdm commented Sep 24, 2018

@bors-servo r=Manishearth

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 24, 2018

📌 Commit 8f50cb1 has been approved by Manishearth

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 24, 2018

⌛️ Testing commit 8f50cb1 with merge 59a69a0...

bors-servo added a commit that referenced this pull request Sep 24, 2018

Auto merge of #440 - servo:macfix, r=Manishearth
Work around inconsistent padding from different LLVM versions.

This allows building with LLVM 4 or 6 and unbreaks my mac cross-compilation.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/440)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 24, 2018

💔 Test failed - status-travis

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 24, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Manishearth
Pushing 59a69a0 to master...

@bors-servo bors-servo merged commit 8f50cb1 into master Sep 24, 2018

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment